chore: update to locale#358
Merged
cre8 merged 1 commit intoopenwallet-foundation:mainfrom Jan 16, 2026
Merged
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra
requested review from
aceshim,
berendsliedrecht,
cre8,
lukasjhan and
zustkeeper
as code owners
Contributor
|
maybe add a |
Contributor
Author
|
I added it already, or what do you mean? |
Contributor
|
Ah, I didn't see the comment. Pushing a feature to mark it as breaking should be fine for me |
cre8
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In draft 13 lang was changed to locale. I have implemented it right now that
langis automatically transformed to locale during validation. This ensures the output type always useslocale(new) but the input type can be both for now (to not break validation immediately).Technically this is a breaking change, so not sure if we want to release this as 0.19 or 0.18.2?